Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculation fixes #47

Closed
wants to merge 16 commits into from
Closed

Calculation fixes #47

wants to merge 16 commits into from

Conversation

DMoenks
Copy link
Owner

@DMoenks DMoenks commented May 14, 2024

Calculation performance improvements/corrections, additional rule filters

@@ -1096,6 +1199,7 @@
$managedDeviceCount += $managedDevices.Count
$URI = $data['@odata.nextLink']
# Analyze managed devices
#TODO: Verify calculation for correctness based on license terms

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
azure-ad-license-status.psm1 Fixed Show fixed Hide fixed
azure-ad-license-status.psm1 Fixed Show fixed Hide fixed
@DMoenks DMoenks closed this Jul 1, 2024
@DMoenks
Copy link
Owner Author

DMoenks commented Jul 1, 2024

Pull request is retracted, additional rule filters need to be reworked to fulfill the intended needs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant