-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQL packaging #20
SQL packaging #20
Conversation
The 0.6.0 package creates a SqlDataProviders folder in the root of the website with all of the PolyDeploy SQL scripts
Thanks for bringing this to our attention Brian, I had absolutely no idea that PolyDeploy was dropping its I've been trying to test this today but unfortunately I receive an installation error. I did a little trial and error and found that by replacing the Have you encountered anything similar? |
PolyDeploy/PolyDeploy.dnn
Outdated
@@ -66,31 +66,31 @@ | |||
|
|||
<component type="Script"> | |||
<scripts> | |||
|
|||
<basePath>DesktopModules/Cantarus/PolyDeploy/</basePath> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can only seem to get the installation to succeed if I change this value to DesktopModules\Cantarus\PolyDeploy\
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please can you remove the trailing slash from this path.
Weird, I don't think I've ever run into the slashes making a difference in a |
Yeah I thought it was weird too. I did a little more digging and I think I've found the problem. It's not actually to do with whether forward or backward slashes are used although the use of backward slashes will mitigate the issue seemingly. The problem is actually that if the I've opened an issue with DNN dnnsoftware/Dnn.Platform#2059. Not critical but might avoid others tracing the same problem through the source. We'll just omit the trailing forward slash. |
PolyDeploy/PolyDeploy.dnn
Outdated
@@ -66,31 +66,31 @@ | |||
|
|||
<component type="Script"> | |||
<scripts> | |||
|
|||
<basePath>DesktopModules/Cantarus/PolyDeploy/</basePath> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please can you remove the trailing slash from this path.
@can-anierzad thanks for tracking that down. I've made the requested change. Let me know if there's anything else. |
The 0.6.0 package creates a
SqlDataProviders
folder in the root of the websitewith all of the PolyDeploy SQL scripts. This PR updates the packaging to put them in
DesktopModules/Cantarus/PolyDeploy/SqlDataProviders