Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL packaging #20

Merged
2 commits merged into from
May 9, 2018
Merged

SQL packaging #20

2 commits merged into from
May 9, 2018

Conversation

bdukes
Copy link
Contributor

@bdukes bdukes commented Mar 28, 2018

The 0.6.0 package creates a SqlDataProviders folder in the root of the website
with all of the PolyDeploy SQL scripts. This PR updates the packaging to put them in DesktopModules/Cantarus/PolyDeploy/SqlDataProviders

The 0.6.0 package creates a SqlDataProviders folder in the root of the website
with all of the PolyDeploy SQL scripts
@ghost
Copy link

ghost commented May 8, 2018

Thanks for bringing this to our attention Brian, I had absolutely no idea that PolyDeploy was dropping its SqlDataProviders folder at the root of the website.

I've been trying to test this today but unfortunately I receive an installation error. I did a little trial and error and found that by replacing the / with \ in the basePath that everything runs smoothly and as expected.

Have you encountered anything similar?

@@ -66,31 +66,31 @@

<component type="Script">
<scripts>

<basePath>DesktopModules/Cantarus/PolyDeploy/</basePath>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can only seem to get the installation to succeed if I change this value to DesktopModules\Cantarus\PolyDeploy\.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you remove the trailing slash from this path.

@ghost ghost self-assigned this May 8, 2018
@bdukes
Copy link
Contributor Author

bdukes commented May 8, 2018

Weird, I don't think I've ever run into the slashes making a difference in a .dnn file, but if it works the other way, that sounds good to me

@ghost
Copy link

ghost commented May 9, 2018

Yeah I thought it was weird too.

I did a little more digging and I think I've found the problem. It's not actually to do with whether forward or backward slashes are used although the use of backward slashes will mitigate the issue seemingly. The problem is actually that if the basePath features a trailing forward slash DNN will replace it with two back slashes in addition to the two back slashes it has already appended because it thought there was no trailing back slash.

I've opened an issue with DNN dnnsoftware/Dnn.Platform#2059. Not critical but might avoid others tracing the same problem through the source.

We'll just omit the trailing forward slash.

@@ -66,31 +66,31 @@

<component type="Script">
<scripts>

<basePath>DesktopModules/Cantarus/PolyDeploy/</basePath>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you remove the trailing slash from this path.

@bdukes
Copy link
Contributor Author

bdukes commented May 9, 2018

@can-anierzad thanks for tracking that down. I've made the requested change. Let me know if there's anything else.

@ghost ghost merged commit 708e6b2 into DNNCommunity:development May 9, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant