Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snapcraft.yaml (support snap packaging). #1

Closed
wants to merge 3 commits into from

Conversation

mpontillo
Copy link

@mpontillo mpontillo commented May 30, 2017

This isn't ready to merge yet, but I wanted to put this out for comments.

I wanted to run dnsperf on Ubuntu, and after finding this gist, I thought I'd try creating a snap for it.

I've registered the dnsperf name for the moment in order to publish the snap, If Nominum would like to maintain the snap, I believe there is a way to transfer ownership.

Things that should happen before this merges:

  • Remove mpontillo from github URL in snapcraft.yaml (used for publishing).
  • Nominum should take ownership of the dnsperf name and build the snap on the snapcraft builder.
  • The version in snapcraft.yaml should be automatically determined from the source code (such as per the script snippet). I'm not sure how that works with automated CI, given the apparent chicken-and-egg problem there.
  • Consider including the sample query data in the snap.
  • Take a closer look at permissions so that the confinement can be increased.

To test this, you can do the following on a recent Ubuntu release (such as 16.04 "Xenial"):

snap install --devmode --beta dnsperf

In order to enable strict confinement, the snap should be tested in jail mode, such as by installing it like this:

snap install --jailmode --beta dnsperf

However, in order for this to work, the snap will need to get the appropriate permissions. Currently it raises errors such as:

../../../../lib/isc/unix/net.c:151: socket() failed: Permission denied
../../../../lib/isc/unix/net.c:151: socket() failed: Permission denied
Error: socket: Permission denied

That said, given that this tool does not seem to change very much, I'm happy to continue publishing the snap myself for now.

mpontillo and others added 3 commits May 30, 2017 11:50
Hey Mike, thanks for snapping dnsperf as well! Here's another snap build badge.
@pemensik
Copy link
Contributor

Hi, just noted on page https://snapcraft.io/install/dnsperf/debian, that it says license Proprietary. I think that should be fixed. It says Apache License 2.0 in LICENSE file.

@jelu
Copy link
Member

jelu commented Nov 25, 2020

Snap is not "packaging" system OARC supports and because of that I will not merge this.

@mpontillo is welcome to continue to be the maintainer for that but then an update as @pemensik noted is required.

@jelu jelu closed this Nov 25, 2020
@mpontillo
Copy link
Author

Thanks for the heads up. I'm setting the dnsperf snap to Unpublished at this time, since I no longer have time to maintain it. If you (or another maintainer) change your mind and would like to release dnsperf as a snap, please let me know and I'll be happy to transfer control of the snap name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants