Create a CSV from a set of applications

[richard-jones]

No description provided.

[emanuil-tolev]

The latest build about this seems to be failing https://drone.io/github.com/DOAJ/doaj/105 ?

[richard-jones]

build is now fixed - minor change to what gets returned by get_colnumber had affected the test.

[Steven-Eardley]

@richard-jones, how do your created CSVs (via portality/reapplication.py) relate to BulkReapplication() objects (from portality/models/reapplication.py)? Will the CSVs be made using the latter model, or will the model be created at the same time from the same information?

[Steven-Eardley]

I ask because we discussed tying them together by naming the CSV file with the Bulk_Reapplication's ID, plus it contains the 'friendly display name' for the spreadsheet.

[richard-jones]

portality.reapplication.make_csv is just a utility for turning a bunch of model.Suggestion objects into a CSV at some given location. So, it's up to some calling code - most likely in the script which initialises the reapplication overall (cc @nimphal / @emanuil-tolev for issue #309 ) - to utilise it.

I'm imagining something like:

reapps = []
for journal in journals_for_this_publisher:
    reapps.append(journal.make_reapplication())

bulkreapp = models.BulkReapplication()
bulkreapp.spreadsheet_name = publisher + ".csv"
bulkreapp.make_id() # or however this is done
reapplication.make_csv(app.config.get("BULK_REAPP_PATH") + bulkreapp.id + ".csv", reapps)
bulkreapp.save()

[emanuil-tolev]

@richard-jones I'm not deleting the feature/reapp_csv branch yet as you may need to rebase your csv validate branch on it again, to include this test fix you just did. I'll pick it up and delete it at some point in the future. once the csv work is complete.