Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAO support revocation lists #1830

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

caoxiaolins
Copy link
Contributor

TAO support revocation lists

@caoxiaolins
Copy link
Contributor Author

There's an issuse with a cyclomatic complexity of 130. However, the cyclomatic complexity of this function was high before. Can I ignore this issuse? @jwillemsen

@caoxiaolins caoxiaolins marked this pull request as draft May 6, 2022 08:11
@jwillemsen
Copy link
Member

Complexity is not a problem

ACE/ace/SSL/SSL_Context.h Show resolved Hide resolved
TAO/orbsvcs/orbsvcs/SSLIOP/SSLIOP_Factory.cpp Show resolved Hide resolved
TAO/orbsvcs/orbsvcs/SSLIOP/SSLIOP_Factory.cpp Show resolved Hide resolved
TAO/orbsvcs/orbsvcs/SSLIOP/SSLIOP_Factory.cpp Outdated Show resolved Hide resolved
@jwillemsen jwillemsen removed their request for review May 11, 2022 06:55
@caoxiaolins caoxiaolins marked this pull request as ready for review May 11, 2022 12:25
@jwillemsen jwillemsen removed their request for review May 11, 2022 12:32
@jwillemsen
Copy link
Member

Please don't assign me as reviewer, my free time for github reviews is very limited, when you need a guaranteed response/review from my side, see https://www.remedy.nl for our services, without being payed for my time you have to wait until I have spare time which I can't tell when I have.

@jwillemsen jwillemsen removed their request for review May 11, 2022 12:41
@jwillemsen jwillemsen removed their request for review May 11, 2022 14:44
@jwillemsen
Copy link
Member

Don't keep assigning my as reviewer, you have to wait until I have free time or fund my time! There is a huge list of things to do on ACE/TAO and sponsoring is welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants