New ACE test: check if ACE_Singleton works after ACE::fini, ACE::init #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some lock types work, others don't, due to different logic per lock type in ACE_Object_Manager::get_singleton_lock and how ACE_Singleton uses it.
|
Do we have an issue for the problem this test reproduced? @mitza-oci are you working on a fix? |
|
I wanted to get the test committed first to see that it compiles on all platforms. I know of two possible fixes, either one should be sufficient and just changes a few lines. I want to do some more research in to how the bug got there. |
|
ok, thanks for the info |
|
MinGW fails, see http://buildlogs.remedy.nl/win_mingw64_64_acetao, probably the mpc file changes |
|
Right, I will fix it in the upcoming pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some lock types work, others don't, due to different logic per lock type
in ACE_Object_Manager::get_singleton_lock and how ACE_Singleton uses it.