Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lrowacphomap with versioned defaults for PHOALGO and PHOPARCUBE parameters #5452

Merged

Conversation

cordellmichaud
Copy link
Contributor

@cordellmichaud cordellmichaud commented Apr 2, 2024

Added versioned default values to lrowacphomap's PHOALGO and PHOPARCUBE parameters and updated lrowacphomap to handle them properly.

Description

  • lrowacphomap's XML documentation has been updated with the versioned defaults and a history entry has been added.
  • lrowacphomap has been updated to expand ISIS preferences and environment variables as well as update version identifiers with the highest version if present for the PHOALGO and PHOPARCUBE parameters.
  • Two functional tests have been added to verify the output produced with the PHOALGO and PHOPARCUBE defaults.

Related Issue

#5451

How Has This Been Validated?

Existing lrowacphomap tests pass, and two new test cases have been added to test output produced with the new default values active.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Infrastructure change (changes to things like CI or the build system that do not impact users)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have added myself to the .zenodo.json document.
  • I have added my user impacting change to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

AustinSanders
AustinSanders previously approved these changes Apr 5, 2024
Copy link
Contributor

@AustinSanders AustinSanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good pending passing tests.

AustinSanders
AustinSanders previously approved these changes Apr 5, 2024
Copy link
Contributor

@AustinSanders AustinSanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved merge conflicts with changelog.

Should be good to go after passing tests

@cordellmichaud
Copy link
Contributor Author

I fixed the error I missed. Lrowacphomap tests are all passing now.

@amystamile-usgs
Copy link
Contributor

@michaudcordell please rebase this PR against the dev branch. I am seeing merge conflicts with the changelog when trying to run this PR against our entire test suite. Thanks!

@cordellmichaud
Copy link
Contributor Author

The merge conflicts should be resolved.

Copy link
Contributor

@amystamile-usgs amystamile-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests are passing.

@amystamile-usgs amystamile-usgs merged commit 625b7f0 into DOI-USGS:dev Jul 16, 2024
@github-actions github-actions bot added the enhancement New feature or request label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants