-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update lrowacphomap with versioned defaults for PHOALGO and PHOPARCUBE parameters #5452
Update lrowacphomap with versioned defaults for PHOALGO and PHOPARCUBE parameters #5452
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good pending passing tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved merge conflicts with changelog.
Should be good to go after passing tests
I fixed the error I missed. Lrowacphomap tests are all passing now. |
@michaudcordell please rebase this PR against the dev branch. I am seeing merge conflicts with the changelog when trying to run this PR against our entire test suite. Thanks! |
The merge conflicts should be resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tests are passing.
Added versioned default values to lrowacphomap's PHOALGO and PHOPARCUBE parameters and updated lrowacphomap to handle them properly.
Description
Related Issue
#5451
How Has This Been Validated?
Existing lrowacphomap tests pass, and two new test cases have been added to test output produced with the new default values active.
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: