Changed old scipy rotation calls to new ones #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessemapel
commented
Feb 8, 2021
| @@ -14,7 +14,7 @@ dependencies: | |||
| - pytz | |||
| - python | |||
| - python-dateutil | |||
| - scipy | |||
| - scipy>=1.4.0 | |||
There was a problem hiding this comment.
The from_matrix and as_matrix methods were added in 1.4.0, the old as_dcm and from_csm methods were finally removed in 1.6.0
kberryUSGS
approved these changes
Feb 10, 2021
jessemapel
added a commit
that referenced
this pull request
May 30, 2022
* Changed old scipy rotation calls to new ones * Updated scipy pinning
jrcain-usgs
pushed a commit
to jrcain-usgs/ale
that referenced
this pull request
May 19, 2023
* Changed old scipy rotation calls to new ones * Updated scipy pinning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scipy changed their rotation API with 1.6.0 and so we need to change up our code a little bit. Fixes #398