Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added apollo metric driver, tests, and data #533

Merged
merged 15 commits into from
Feb 21, 2024

Conversation

AustinSanders
Copy link
Contributor

Added apollo metric driver, tests, and data

Part of ALE driver sprint

Copy link
Collaborator

@acpaquette acpaquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great! Just needs a changelog entry

ale/drivers/apollo_drivers.py Outdated Show resolved Hide resolved
@acpaquette acpaquette self-requested a review May 15, 2023 22:42
acpaquette
acpaquette previously approved these changes May 15, 2023
@acpaquette
Copy link
Collaborator

@AustinSanders Looks like the load test is failing

@acpaquette
Copy link
Collaborator

Seems like the test can't find the driver

@AustinSanders
Copy link
Contributor Author

I'm not sure why... This is passing locally. I can look into it

@acpaquette
Copy link
Collaborator

@AustinSanders Looks like some xsp files were not added to the PR. I get the following error when running local with verbose output.

At least one SPK file needs to be loaded by SPKLEF before beginning a search.

CHANGELOG.md Outdated Show resolved Hide resolved
@acpaquette acpaquette merged commit bc50c79 into DOI-USGS:main Feb 21, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants