-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ALE driver verification script addition #584
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #584 +/- ##
==========================================
- Coverage 15.82% 15.47% -0.35%
==========================================
Files 56 57 +1
Lines 6283 6424 +141
==========================================
Hits 994 994
- Misses 5289 5430 +141 ☔ View full report in Codecov by Sentry. |
…ad in a PVLModule
…ested and run against to find one that works. there is a small note to make about the use of pvl.loads() in this script. I commented out 2 lines using that function and had to change to variable names in the subsequent lines as this pvl.loads() function won't work as expected until DOI-USGS#587 is merged to apply the bug fix to that method; that fix will allow ale.loads() to read in PVLObjects, currently because the lines are commented ale.loads() just reads in the image files themselves which still works but requires more overhead in ale.loads().
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, couple of things to address then this can get merged
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:
This adds a script for driver verification wherein a image is run through both ALE and ISIS and then compared to see how different ALE drivers compare to ISIS' spiceinit in order to better compare how spice data is utilized through both for image ingestion. An example of it's usage is as follows:
python3 driver_verification.py ClementineIsisLabelNaifSpiceDriver LUA3107H.161.clem.cub
Output will look similar to the following: