Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9 30 images #4

Merged
merged 3 commits into from
Sep 30, 2020
Merged

9 30 images #4

merged 3 commits into from
Sep 30, 2020

Conversation

ellenbechtel
Copy link
Contributor

Before making a pull request

First . . .

  • Clean the code the way Vue likes it - run 'npm run lint --fix'
  • Make sure all tests run

Then check for accessibly compliance

  • Run WAVE plugin 508 compliance tool

Then run Browserstack; check that application works on . . .

  • Chrome
  • Safari
  • Edge
  • Firefox
  • Samsung Internet
  • Internet Explorer 11 (not supported, but still needs at least a working user redirect page)

Finally . . .

  • Update the changelog appropriately

Added image carousel

Brief description of changes. Reference the JIRA ticket if appropriate

Description

If no ticket is referenced, describe the changes made. Note anything that you want the reviewers to know while
reviewing your pull request

After making a pull request

  • If appropriate, put the link to the PR in the ticket
  • Assign someone to review unless the change is trivial

@ellenbechtel ellenbechtel merged commit b91e193 into DOI-USGS:master Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant