Update with ice fix #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 8, 2021 16:18
Merge branch 'master' of github.com:jread-usgs/mntoha-data-release # Conflicts: # log/02_observations_sb.csv # log/03_configPB_sb.csv # log/04_inputs_sb.csv # log/05_predictionsPB_sb.csv # log/06_evaluationPB_sb.csv
lindsayplatt
reviewed
Apr 9, 2021
|
yes, but only in subtle ways. Irradiance will change if ice-cover changes, since it is calculated as the amount of energy available just at the surface of the water (so below snow and ice). I will check as to why clarity changed - I can't remember if this also is a model export (which would explain a subtle change) or it is an external input that shouldn't change w/ this update. |
|
Yes, I confirmed that clarity is extracted from the model output file as opposed to taken from the inputs. So it makes sense that it changed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re-ran all GLM3 models after this: DOI-USGS/lake-temperature-process-models#30