-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes scale/offset error. #206
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #206 +/- ##
==========================================
- Coverage 53.46% 53.44% -0.03%
==========================================
Files 35 35
Lines 2381 2382 +1
==========================================
Hits 1273 1273
- Misses 1108 1109 +1 ☔ View full report in Codecov by Sentry. |
The 3.8 build is failing because coverage.io is throttling. Otherwise, this is good to go! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good.
Can we open an issue for the CSM translation table addition and link it here? Otherwise, the change just kind of sneaks into this PR and will be hard to track.
@AustinSanders There is this issue open on ISIS. DOI-USGS/ISIS3#5485 I think the discussion point (for that issue?) relates to whether or not CSM sensor models used with ISIS cubes should have a different serial number or not. |
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: