Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes scale/offset error. #206

Merged
merged 5 commits into from
Jun 8, 2024
Merged

Fixes scale/offset error. #206

merged 5 commits into from
Jun 8, 2024

Conversation

jlaura
Copy link
Collaborator

@jlaura jlaura commented Apr 17, 2024

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 53.44%. Comparing base (f0b0bba) to head (844b3c4).

Files Patch % Lines
plio/io/isis_serial_number.py 75.00% 3 Missing ⚠️
plio/io/io_gdal.py 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #206      +/-   ##
==========================================
- Coverage   53.46%   53.44%   -0.03%     
==========================================
  Files          35       35              
  Lines        2381     2382       +1     
==========================================
  Hits         1273     1273              
- Misses       1108     1109       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jlaura
Copy link
Collaborator Author

jlaura commented Jun 4, 2024

The 3.8 build is failing because coverage.io is throttling. Otherwise, this is good to go!

Copy link
Contributor

@AustinSanders AustinSanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good.

Can we open an issue for the CSM translation table addition and link it here? Otherwise, the change just kind of sneaks into this PR and will be hard to track.

@jlaura
Copy link
Collaborator Author

jlaura commented Jun 7, 2024

@AustinSanders There is this issue open on ISIS. DOI-USGS/ISIS3#5485

I think the discussion point (for that issue?) relates to whether or not CSM sensor models used with ISIS cubes should have a different serial number or not.

@jlaura jlaura merged commit e158823 into DOI-USGS:main Jun 8, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants