Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USGSCSM Internal Dependency Building #445

Merged
merged 29 commits into from
Jan 23, 2024
Merged

Conversation

acpaquette
Copy link
Collaborator

@acpaquette acpaquette commented Aug 8, 2023

Updates USGSCSM to build everything internally

This PR integrates ALE and PROJ into USGSCSM and only building the parts that USGSCSM needs

environment.yml Outdated
- eigen
- nlohmann_json
- proj
- sqlite
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is concerning because many packages depend upon sqlite. For example:

Does the usgscsm depend on sqlite or is this because of the projection stuff inside the CSM?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think our last test build also needed the curl lib, unless that was removed from the build.
https://github.com/OSGeo/PROJ/blob/a654e42074a167a03e1e3ff7c2009c04502830bf/docs/source/install.rst#build-requirements

I can currently work-around the extra libs for SocetGXP, but it is not graceful. Ideally, bundling proj with usgscsm can be maybe optional (at least for Windows) but I'm not sure how best to resolve this.

@acpaquette acpaquette changed the title USGSCSM 1.7.0 release prep USGSCSM Internal Dependency Building Aug 10, 2023
Comment on lines +2 to 9
{% set name = "usgscsm" %}
{% set version = "main" %}

package:
name: usgscsm
version: {{ environ.get("GIT_DESCRIBE_TAG", "") }}
name: {{ name|lower }}
version: {{ version }}

source:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine we would also need a PR to the feedstock to update the recipe?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this was just for internal testing that is similar to the feedstock. That's the next thing I will have to tackle once I pull a new release

CMakeLists.txt Outdated Show resolved Hide resolved
@Kelvinrr Kelvinrr merged commit 66a05db into DOI-USGS:main Jan 23, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants