Windows compat #130
Merged
Windows compat #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
cli/ecqm_dedupe.py
Outdated
| @@ -56,8 +57,12 @@ def dedupe_data(fmt,bad_data_path, output_path,linker=None): #pylint: disable=un | |||
| unique_records = deduped_record_mapping.drop_duplicates(subset=['cluster_id']) | |||
| #cache results | |||
| #TODO: make platform agnostic | |||
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0511: TODO: make platform agnostic (fixme)
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
IsaacMilarky
commented
Sep 4, 2024
| import pandas as pd | ||
| import click | ||
| from splink import block_on | ||
| from deduplifhirLib.utils import use_linker | ||
|
|
||
|
|
||
| CACHE_DIR = "/tmp/" | ||
| CACHE_DIR = tempfile.gettempdir() |
There was a problem hiding this comment.
From Python Docs:
A platform-specific location:
On Windows, the directories C:\TEMP, C:\TMP, \TEMP, and \TMP, in that order.
On all other platforms, the directories /tmp, /var/tmp, and /usr/tmp, in that order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Paths Not Being Windows-Friendly
Problem
Right now the Paths in the CLI assume unix style paths. Although, we want to support Windows users.
Solution
Used the os and tempfile modules to make the CLI platform agnostic.
Result
Summary:
os.path.joinTest Plan
Sarah will run this on her Windows machine 🪟