Fix SSO bug for email addresses with capital letters #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Devise will convert the `email` field to lowercase, as configured by config.case_insensitive_keys. When searching for an account, we need to use Devise's `find_for_authentication` method so it will apply the same transformation.
allthesignals
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
N/A - Needed for NYC to log in for dynamic security scan.
Changes
Devise will convert the
emailfield to lowercase, as configured byconfig.case_insensitive_keys. When searching for an account, we need to
use Devise's
find_for_authenticationmethod so it will apply the sametransformation.
Context for reviewers
N/A
Testing
Regression test included. I also tested logging into an existing account as
well as a new account to verify it works.