Remove providers; use selected employer #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
allthesignals
commented
Apr 29, 2024
allthesignals
commented
- Removes the providers resource
- Queries for real employer records
- Uses the selected employer in the Link flow
- Passes the received account id to the next step
tdooner
approved these changes
Apr 29, 2024
| @@ -63,6 +66,13 @@ def fetch_and_store_argyle_token | |||
| parsed['user_token'] | |||
| end | |||
|
|
|||
| def fetch_employers | |||
| res = Net::HTTP.get(URI.parse(ITEMS_ENDPOINT), {"Authorization" => "Basic #{ENV['ARGYLE_API_TOKEN']}"}) | |||
There was a problem hiding this comment.
I think we will want to use .get_response for real things just so we have better ability to handle errors. But no sense in fixing it here if all that error handling will happen in the Argyle service that George is working on.
There was a problem hiding this comment.
Yeahhh I don't love it. If you don't feel strongly about it I'll go ahead and merge. Let's see what the service class does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.