generated from DSACMS/.github
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Repometrics Endpoint to Fetch Values #171
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RicardoZamora01
requested review from
IsaacMilarky,
natalialuzuriaga and
decause-gov
July 5, 2024 18:27
Signed-off-by: Ricardo Zamora <rzgarcia27@gmail.com>
RicardoZamora01
force-pushed
the
ricardo/fetch-repometrics
branch
from
July 8, 2024 17:53
84d7965
to
b7a1d2a
Compare
Signed-off-by: Ricardo Zamora <rzgarcia27@gmail.com>
Signed-off-by: Ricardo Zamora <rzgarcia27@gmail.com>
Signed-off-by: Ricardo Zamora <rzgarcia27@gmail.com>
Signed-off-by: Ricardo Zamora <rzgarcia27@gmail.com>
Signed-off-by: Ricardo Zamora <rzgarcia27@gmail.com>
Should be working for DedupliFHIR and Metrics once their recent changes (adding code.json) are deployed to main! 😸 |
natalialuzuriaga
approved these changes
Jul 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran update.sh and code.json fields were added to DedupliFHIR data json!!! LGTM 👍
IsaacMilarky
approved these changes
Jul 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Repometrics Endpoint to Fetch Values
Problem
Projects will now have repometrics in a code.json file. There is currently no way to fetch these metric values to add them to the report.
Solution
Added the repometrics endpoint using the raw json link to append them to the simple metrics list, which will be used to fetch metrics values.