Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change region to 'us-east-1' and set custom exception for incomplete AWS credential steps #1085

Merged
merged 8 commits into from
Jan 1, 2024

Conversation

LuHG18
Copy link
Collaborator

@LuHG18 LuHG18 commented Jan 1, 2024

Change region to 'us-east-1' and set custom exception for incomplete AWS credential steps

Github Issue Number Here: #1084
Issue Description
Bug preventing access to user id tokens through the dlp-cli with unclear error message

Solution
Edited cli.py file to use the correct region (us-east-1) and added custom exception providing a more detailed error description in the case where dlp-cli user did not complete the necessary AWS credential steps.

Testing Methodology
Tested the updates by using the dlp-cli to obtain a valid id token. First by not completing the proper AWS credential steps to prompt the custom exception and second by filling out the necessary steps and successfully getting the token.

https://drive.google.com/file/d/1jThsq6Xznm4oAS_NN-o_Yt-7nBc_K5v_/view?usp=sharin

@LuHG18 LuHG18 requested a review from a team as a code owner January 1, 2024 18:59
Copy link
Contributor

sweep-ai bot commented Jan 1, 2024

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@karkir0003
Copy link
Member

@LuHG18 can you share a video recording/screen recording of you walking through the testing steps :)

training/cli.py Outdated Show resolved Hide resolved
training/cli.py Outdated Show resolved Hide resolved
training/cli.py Outdated Show resolved Hide resolved
training/cli.py Outdated Show resolved Hide resolved
Copy link
Member

@karkir0003 karkir0003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some suggestions + comment on attaching a screen recording to validate the testing steps

@karkir0003
Copy link
Member

Thank you for this PR @LuHG18 🥳

training/cli.py Outdated Show resolved Hide resolved
Copy link
Member

@karkir0003 karkir0003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added another comment

@LuHG18 LuHG18 added this pull request to the merge queue Jan 1, 2024
Copy link

sonarcloud bot commented Jan 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Merged via the queue into nextjs with commit 5ea3235 Jan 1, 2024
4 checks passed
@LuHG18 LuHG18 deleted the bug-1084 branch January 1, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants