-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change region to 'us-east-1' and set custom exception for incomplete AWS credential steps #1085
Conversation
…AWS credential steps
Apply Sweep Rules to your PR?
|
@LuHG18 can you share a video recording/screen recording of you walking through the testing steps :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some suggestions + comment on attaching a screen recording to validate the testing steps
Thank you for this PR @LuHG18 🥳 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added another comment
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Change region to 'us-east-1' and set custom exception for incomplete AWS credential steps
Github Issue Number Here: #1084
Issue Description
Bug preventing access to user id tokens through the dlp-cli with unclear error message
Solution
Edited cli.py file to use the correct region (us-east-1) and added custom exception providing a more detailed error description in the case where dlp-cli user did not complete the necessary AWS credential steps.
Testing Methodology
Tested the updates by using the dlp-cli to obtain a valid id token. First by not completing the proper AWS credential steps to prompt the custom exception and second by filling out the necessary steps and successfully getting the token.
https://drive.google.com/file/d/1jThsq6Xznm4oAS_NN-o_Yt-7nBc_K5v_/view?usp=sharin