Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic error occurs when replying to a Copy Request if you don't have permissions to send a reply #1806

Closed
alawvt opened this issue Sep 1, 2022 · 2 comments

Comments

@alawvt
Copy link

alawvt commented Sep 1, 2022

Describe the bug
A clear and concise description of what the bug is. Include the version(s) of DSpace where you've seen this problem & what web browser you were using. Link to examples if they are public: DSpace 7.3, Firefox

  1. With a personal email, I created an item in DSpace 7 Demo, https://demo7.dspace.org/items/b2fac597-a382-4c0e-82ef-802afca015a0.
  2. As dspacedemo+admin@gmail.com, I restricted the bitstream, https://demo7.dspace.org/items/b2fac597-a382-4c0e-82ef-802afca015a0/request-a-copy?bitstream=bfe2b22e-bca7-4a13-851e-f8f6f5091ec4 to Administrators only.
  3. I requested the item from a second personal account.
  4. I received the request at the first personal email account. I selected "Send copy" and received the error,
    DSpace7_request_copy_reply_error2

To Reproduce
Steps to reproduce the behavior:

  1. Do this
  2. Then this...

Expected behavior
A clear and concise description of what you expected to happen.

Related work
Link to any related tickets or PRs here.

@tdonohue
Copy link
Member

I tested this today and "Request a Copy" is working fine for me locally.

However, I have seen this scenario before, and I suspect you are hitting an authorization issue. For instance, I've seen this same behavior when performing these steps:

  1. Login as "User1" and submit an Item with a restricted Bitstream
  2. Login as "User2" and submit a "request a copy" request to User1 for access to that Bitstream
  3. Now, login as a full Admin (User3) and attempt to reply to that request. User3 can access the "Request a Copy" page, but the reply will fail, because only the user who received the request (Submitter by default) can reply to it.

The person who receives the request depends on your "strategy" configured for Request a Copy. By default, only the original submitter can reply. But, it's possible to specify a different responder if you change the request configuration to use "helpdesk email" or Collection Administrators or Item metadata. See https://wiki.lyrasis.org/display/DSDOC7x/Request+a+Copy#RequestaCopy-SelectingRequestaCopystrategy

All that said, I think the bug here is that the error message returned is not informative. Additionally, the permissions of the user accessing the request a copy page should be checked earlier & you should be blocked from accessing the page if you are not allowed to respond. I'll update this ticket's title to clarify the bug.

@tdonohue tdonohue added usability medium priority and removed needs triage New issue needs triage and/or scheduling labels Oct 31, 2022
@tdonohue tdonohue changed the title Error replying to request a copy Generic error occurs when replying to a Copy Request if you don't have permissions to send a reply Oct 31, 2022
@tdonohue tdonohue moved this to To Do in DSpace 7.5 release Oct 31, 2022
@tdonohue tdonohue moved this to 📋 To Do in DSpace 7.6 Release Feb 27, 2023
@tdonohue
Copy link
Member

This appears to be fixed in 7.6 by #2199

@tdonohue tdonohue added this to the 7.6 milestone Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants