i18n: Placeholder catalogs as a starting point for translators #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdonohue
approved these changes
Nov 21, 2019
There was a problem hiding this comment.
👍 Looks good to me.
Summary of discussions: @bram-atmire and I discussed this PR via Slack today. Bram wants to add these placeholder catalogs to make it easy for translators to simply login to GitHub and click the edit button on an existing json5 language pack. However, I had concerns about creating too many placeholder catalogs at once.
We decided to compromise and only add placeholder catalogs for languages which had a recently updated (in last 2-3 years) translation of the old XMLUI. So, anything in this list that says "3 years ago" or less: https://github.com/DSpace/dspace-xmlui-lang/tree/master/src/main/webapp/i18n
This ensures we are keeping the initial set of "placeholder" catalogs just to those languages which we feel we are likely to find translators (as we've had recent translations contributed). We decided to make an exception for fr.json5 (French), as Bram has a possible translator already lined up.
artlowel
approved these changes
Nov 22, 2019
kosarko
pushed a commit
to kosarko/dspace-angular
that referenced
this pull request
May 20, 2024
* Update docker.yml (DSpace#452) It was run only for `dspace` repository * The BE was started without instance (DSpace#453) * Copying of solr configs were missing from the docker-compose-rest (DSpace#454) * configured path (DSpace#455) try to append server/ to test gh action * Internal/run container in production mode (DSpace#456) * Added NODE_ENV=production because the container is trying to run in development mode * Use Vanilla dspace-ui.json instead of ours from root. * Updated path for running `dspace-ui.json` * Use ENV - production in the dspace-ui.json (DSpace#457) * The docker-compose-rest has defined network which is not the same like in the cli.yml - it throws an error (DSpace#458) * Update deploy.yml (DSpace#459) Allowed S3 * Update deploy.yml (DSpace#461) Use .env file from the dev5 instead of createing a new one in the github action * Update deploy.yml (DSpace#462) Working directory was missing * ufal/cannot-login-after-upgrade Merge pull request DSpace#2731 from DSpace/backport-2670-to-main (DSpace#512) [Port main] Ensure HALEndpointService doesn't use stale responses Co-authored-by: Tim Donohue <tim.donohue@lyrasis.org> * ufal/cannot-load-user-metadata Added searchData because it was null (DSpace#514) * ufal/license-agreement-multiple-records (DSpace#516) * Load required input fields only if are loaded user metadata or the user is anonymous * Added ID into ClarinUserRegistration model * Added a search method in the userMetadataService * The filtered user metadata are loaded from the BE * internal/update-deploy-s3-props (DSpace#448) * Update deploying customer/uk - there weren't right S3 properties. * ufal/discojuice-not-popped-up (DSpace#515) * Use cookie to popup discojuice login. * Added Cookie Service into tests * Close discojuice if it is popped up * Do not import commands in the constants file. * commands must be imported in the e2e.ts * ufal/search-page-without-results (DSpace#517) * Use ClarinSearch instead of Vanilla one - updated themed component * Added updates from the vanilla upgrade into clarin-search.component.ts * Removed empty my-dspace file * Maybe IT will be passed with vanilla search component * Fixed my-dspace integration tests, they failed because the clarin-search was filtering only Items and integration tests exceted publication and other types * Do not close discojuice login if it is not popped up * internal/fix-deploy-s3-props * ufal/s3-checksum-improvements (DSpace#518) * Do not compute checksum on null object.. * The checksum is computed only after the download button is clicked. * Added tests to check the checksum won't be loaded on init * Fixed accidentally updated message key --------- Co-authored-by: Jozef Misutka <332350+vidiecan@users.noreply.github.com> Co-authored-by: MajoBerger <marian.berger@dataquest.sk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting file for all languages that are present in the XMLUI message catalog.