fix: upgrade SpreadSheet component for can be bind with ref #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
mumiao
pushed a commit
that referenced
this pull request
Nov 7, 2023
* fix(useList): initialParams suppport function type (#393) * build(deps-dev): bump browserify-sign from 4.2.1 to 4.2.2 (#399) Bumps [browserify-sign](https://github.com/crypto-browserify/browserify-sign) from 4.2.1 to 4.2.2. - [Changelog](https://github.com/browserify/browserify-sign/blob/main/CHANGELOG.md) - [Commits](browserify/browserify-sign@v4.2.1...v4.2.2) --- updated-dependencies: - dependency-name: browserify-sign dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: import highlight core only (#402) * feat: import highlight core only * feat: improve Hljs types * feat: add sideEffects field to improve treeShaking (#403) * fix: upgrade SpreadSheet component for can be binded ref (#404) Co-authored-by: zhaoge <> * feat: add search component on sidebar (#405) * feat: develop modal * feat(Modal): improve banner check * test: add test cases --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Hayden <hayden9653@gmail.com> Co-authored-by: XCynthia <942884029@qq.com>
mumiao
pushed a commit
that referenced
this pull request
Nov 14, 2023
* fix(useList): initialParams suppport function type (#393) * build(deps-dev): bump browserify-sign from 4.2.1 to 4.2.2 (#399) Bumps [browserify-sign](https://github.com/crypto-browserify/browserify-sign) from 4.2.1 to 4.2.2. - [Changelog](https://github.com/browserify/browserify-sign/blob/main/CHANGELOG.md) - [Commits](browserify/browserify-sign@v4.2.1...v4.2.2) --- updated-dependencies: - dependency-name: browserify-sign dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: import highlight core only (#402) * feat: import highlight core only * feat: improve Hljs types * feat: add sideEffects field to improve treeShaking (#403) * fix: upgrade SpreadSheet component for can be binded ref (#404) Co-authored-by: zhaoge <> * feat: add search component on sidebar (#405) * feat: develop modal * feat(Modal): improve banner check * test: add test cases --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Hayden <hayden9653@gmail.com> Co-authored-by: XCynthia <942884029@qq.com>
mumiao
added a commit
that referenced
this pull request
Nov 14, 2023
* Feat update slide pane (#385) * feat: update slidePane for mask * feat(slidepane): add tabs for slidepane * feat(slidepane): update motion for slidePane * feat(slidepane): update ts error and style * feat(slidepane): update doc and unit test * fix(slidepane): update props name and edit showMask to mask * fix(unittest): update unit test * fix(slidepane): update ts type * feat: add tinyTag (#396) * feat: add tinyTag * feat: support HTMLSpanElement's Attributes and color * docs: update docs * Feat image (#395) * feat(intersectionobserver): add IntersectionObserver hook * feat(intersectionobserver): update IntersectionObserver unit test * feat(useintersectionobserver): use ref and add freezeOnceVisible * feat(useintersectionobserver): update test unit * feat(image): add image component * feat(image): update review comment and mock window.Image * feat(image): add image test * feat(contentlayout): add contentLayout (#384) * feat(contentlayout): add contentLayout * feat(contentlayout): update contentLayout export table/header * feat(contentlayout): update contentLayout info * feat: update contentLayout md * feat(contengtlayout): update contentLayout md * feat(contentlayout): update some props * feat: develop modal (#401) * fix(useList): initialParams suppport function type (#393) * build(deps-dev): bump browserify-sign from 4.2.1 to 4.2.2 (#399) Bumps [browserify-sign](https://github.com/crypto-browserify/browserify-sign) from 4.2.1 to 4.2.2. - [Changelog](https://github.com/browserify/browserify-sign/blob/main/CHANGELOG.md) - [Commits](browserify/browserify-sign@v4.2.1...v4.2.2) --- updated-dependencies: - dependency-name: browserify-sign dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: import highlight core only (#402) * feat: import highlight core only * feat: improve Hljs types * feat: add sideEffects field to improve treeShaking (#403) * fix: upgrade SpreadSheet component for can be binded ref (#404) Co-authored-by: zhaoge <> * feat: add search component on sidebar (#405) * feat: develop modal * feat(Modal): improve banner check * test: add test cases --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Hayden <hayden9653@gmail.com> Co-authored-by: XCynthia <942884029@qq.com> * Feat utils (#409) * build(deps-dev): bump browserify-sign from 4.2.1 to 4.2.2 (#399) Bumps [browserify-sign](https://github.com/crypto-browserify/browserify-sign) from 4.2.1 to 4.2.2. - [Changelog](https://github.com/browserify/browserify-sign/blob/main/CHANGELOG.md) - [Commits](browserify/browserify-sign@v4.2.1...v4.2.2) --- updated-dependencies: - dependency-name: browserify-sign dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: remove inner utils and add dt-utils dependence * fix: fix pnpm-lock antd/icon patch version --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: jialan <jialan@dtstack.com> * feat: new component Catalogue in v5 (#389) * feat(Catalogue): new component, catalogue initial * chore(Catalogue): lint * docs: update demo docs * feat: clear searchStr when close search * docs: update demo docs * feat: add defaultStatus & onStatusChange props in Catalogue.DtTree * chore: rename dtTree、dtTreeSelect to Tree、TreeSelect * chore: update demos and docs * chore: treeTit prop exchange to treeTitle --------- Co-authored-by: dilu <dilu@dtstack.com> * feat(filterrules): add FilterRules (#407) * feat(filterrules): add FilterRules * feat(filterrules): update some example * feat(filterrules): add some example and props type and use weakMap to save height/lineheight * feat(filterrules): update ts and add comment * feat(filterrules): update FilterRules props and formitem name * feat(filterrules): add comment and unit test * feat(filterrrules): update contants file and style * test(filterrules): update test unit --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: 霜序 <38368040+LuckyFBB@users.noreply.github.com> Co-authored-by: 野迂迂 <yangwei1@outlook.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Hayden <hayden9653@gmail.com> Co-authored-by: XCynthia <942884029@qq.com> Co-authored-by: JackWang032 <64318393+JackWang032@users.noreply.github.com> Co-authored-by: jialan <jialan@dtstack.com> Co-authored-by: Frank <scofield90.email@gmail.com> Co-authored-by: dilu <dilu@dtstack.com>
mumiao
pushed a commit
that referenced
this pull request
Nov 15, 2023
* fix(useList): initialParams suppport function type (#393) * build(deps-dev): bump browserify-sign from 4.2.1 to 4.2.2 (#399) Bumps [browserify-sign](https://github.com/crypto-browserify/browserify-sign) from 4.2.1 to 4.2.2. - [Changelog](https://github.com/browserify/browserify-sign/blob/main/CHANGELOG.md) - [Commits](browserify/browserify-sign@v4.2.1...v4.2.2) --- updated-dependencies: - dependency-name: browserify-sign dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: import highlight core only (#402) * feat: import highlight core only * feat: improve Hljs types * feat: add sideEffects field to improve treeShaking (#403) * fix: upgrade SpreadSheet component for can be binded ref (#404) Co-authored-by: zhaoge <> * feat: add search component on sidebar (#405) * feat: develop modal * feat(Modal): improve banner check * test: add test cases --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Hayden <hayden9653@gmail.com> Co-authored-by: XCynthia <942884029@qq.com>
mumiao
pushed a commit
that referenced
this pull request
Nov 15, 2023
* fix(useList): initialParams suppport function type (#393) * build(deps-dev): bump browserify-sign from 4.2.1 to 4.2.2 (#399) Bumps [browserify-sign](https://github.com/crypto-browserify/browserify-sign) from 4.2.1 to 4.2.2. - [Changelog](https://github.com/browserify/browserify-sign/blob/main/CHANGELOG.md) - [Commits](browserify/browserify-sign@v4.2.1...v4.2.2) --- updated-dependencies: - dependency-name: browserify-sign dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: import highlight core only (#402) * feat: import highlight core only * feat: improve Hljs types * feat: add sideEffects field to improve treeShaking (#403) * fix: upgrade SpreadSheet component for can be binded ref (#404) Co-authored-by: zhaoge <> * feat: add search component on sidebar (#405) * feat: develop modal * feat(Modal): improve banner check * test: add test cases --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Hayden <hayden9653@gmail.com> Co-authored-by: XCynthia <942884029@qq.com>
mumiao
pushed a commit
that referenced
this pull request
Nov 15, 2023
* fix(useList): initialParams suppport function type (#393) * build(deps-dev): bump browserify-sign from 4.2.1 to 4.2.2 (#399) Bumps [browserify-sign](https://github.com/crypto-browserify/browserify-sign) from 4.2.1 to 4.2.2. - [Changelog](https://github.com/browserify/browserify-sign/blob/main/CHANGELOG.md) - [Commits](browserify/browserify-sign@v4.2.1...v4.2.2) --- updated-dependencies: - dependency-name: browserify-sign dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: import highlight core only (#402) * feat: import highlight core only * feat: improve Hljs types * feat: add sideEffects field to improve treeShaking (#403) * fix: upgrade SpreadSheet component for can be binded ref (#404) Co-authored-by: zhaoge <> * feat: add search component on sidebar (#405) * feat: develop modal * feat(Modal): improve banner check * test: add test cases --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Hayden <hayden9653@gmail.com> Co-authored-by: XCynthia <942884029@qq.com>
mumiao
pushed a commit
that referenced
this pull request
Nov 15, 2023
* fix(useList): initialParams suppport function type (#393) * build(deps-dev): bump browserify-sign from 4.2.1 to 4.2.2 (#399) Bumps [browserify-sign](https://github.com/crypto-browserify/browserify-sign) from 4.2.1 to 4.2.2. - [Changelog](https://github.com/browserify/browserify-sign/blob/main/CHANGELOG.md) - [Commits](browserify/browserify-sign@v4.2.1...v4.2.2) --- updated-dependencies: - dependency-name: browserify-sign dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: import highlight core only (#402) * feat: import highlight core only * feat: improve Hljs types * feat: add sideEffects field to improve treeShaking (#403) * fix: upgrade SpreadSheet component for can be binded ref (#404) Co-authored-by: zhaoge <> * feat: add search component on sidebar (#405) * feat: develop modal * feat(Modal): improve banner check * test: add test cases --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Hayden <hayden9653@gmail.com> Co-authored-by: XCynthia <942884029@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past, spreadsheet is a class component which can be bind with ref directly.But it's changed to a function coponent after upgraded to v4, so what using way of ref won't work.This commit is to upgrade this function component so that ref works as same as past.
以前的Speadsheet是一个类组件，可以直接与ref绑定。但是升级到v4后，它变成了函数组件，所以之前使用ref的方式不起作用。本次提交是升级这个函数组件，以便 ref 的工作方式与过去相同。