Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add module level trigger #4

Merged
merged 16 commits into from
Apr 14, 2021
Merged

Add module level trigger #4

merged 16 commits into from
Apr 14, 2021

Conversation

philiprodrigues
Copy link
Collaborator

This PR adds a ModuleLevelTrigger DAQModule, which takes in TriggerCandidates from the timing system and produces a TriggerDecision for each one, subject to available tokens from the DF subsystem. The PR also contains some fake generators to exercise the MLT and a python confgen to run a simple test setup

@philiprodrigues
Copy some relevant code from the trigemu package. Builds but not test…
dd93c8b 
…ed in any way

TriggerDecisionEmulator is copied and renamed to ModuleLevelTrigger. TimestampEstimator is also copied. Both are so-far unchanged except for naming and package-specific things (eg namespaces, include guards)
@philiprodrigues
Add wait_for_valid_timestamp() and wait_for_timestamp(T) methods to T…
6a08749 
…imestampEstimator, and use them
@philiprodrigues
Move token management logic into TokenManager class
687c450
@philiprodrigues
Use TokenManager in ModuleLevelTrigger
5676230
@philiprodrigues
Remove vestigial inhibit queue functionality
dacb0e3
@philiprodrigues
Update some comments
e5d461b
@philiprodrigues
clang-format all the things
588bf59
@philiprodrigues
Move logic for creating TriggerDecisions every N ticks into IntervalT…
7622dea 
…riggerCreator
@philiprodrigues
Move triggers-at-intervals logic out of MLT and read TriggerCandidate…
ad76691 
…s instead
@philiprodrigues
Split the IntervalTriggerCreator parts out of the MLT schema
5e12041
@philiprodrigues
Rearrange TimestampEstimator so we can have a TimestampEstimatorSyste…
0879939 
…m, which just gives the system-clock time
@philiprodrigues
Add IntervalTCCreator, which creates TCs at fixed intervals
5ec5ab7
@philiprodrigues
Fix many silly bugs
c375442
@philiprodrigues
Add confgen for job with fake TCs fed directly to MLT
4795d88 
This test job uses IntervalTCCreator to create TCs at fixed time intervals (based on the system clock, rather than TimeSync messages). The TCs are fed into the MLT, which turns them into TDs and pushes them to an output queue, where they languish forever, because nothing is popping them.
@philiprodrigues
Add some brief descriptions of classes
f65828c
@philiprodrigues
clang-format all the things
c6604eb
eflumerf
eflumerf approved these changes Apr 14, 2021
View reviewed changes
Copy link
Member

@eflumerf eflumerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that we are still hard-coded to APA0, but a brief code review looks good and the code builds in my test area. Functionality-based tests were not run, and this PR does not add any unit tests (!!).

This was referenced Apr 14, 2021
Closed
Closed
@philiprodrigues philiprodrigues merged commit e44e2b9 into develop Apr 14, 2021
@philiprodrigues philiprodrigues deleted the philiprodrigues/import-trigemu branch April 14, 2021 13:42
CharlieBatchelor pushed a commit that referenced this pull request May 2, 2022
@philiprodrigues
Merge pull request #4 from DUNE-DAQ/philiprodrigues/tc-type
8459fb2 
Change type of `TriggerCandidate::type` to `TriggerCandidateType`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eflumerf eflumerf eflumerf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philiprodrigues @eflumerf