-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mc_truth/interactions #126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In raw_event_generator.py
a couple warning messages are added, but one of them uses print()
and the other uses warning.warn()
. Use print()
or warn()
for both.
Also, what is the purpose of switching between file_vertex_id
and vertex_id
? It looks like it's there as a fallback if the file_
version is not present in the dataset.
use warning instead of a mix of warning and print
@cuddandr addressed the warning comment.
In particle bomb adaption in edepsim, the vertex_id restart from 0 every event and the traj_id restart from 0 every interaction. In the beam simulation vertex_id is unique. I have not looked at the cosmic simulation yet.
|
Fill
mc_truth/interactions
withvertices
when there is nomc_hdr
available.