Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with some recipes not having variants generated #14

Merged
merged 2 commits into from
Mar 1, 2019

Conversation

ReikaKalseki
Copy link
Contributor

Such as mentioned here, as well as I suspect in this case.

I forgot to make it actually work with the .normal and .expensive data in the creator function. :P
@ReikaKalseki
Copy link
Contributor Author

There is one thing left undone with this patch, and that is getting GDIW hotkey working; the flipped recipes exist and can be selected normally, but the hotkey mod seems unable to detect them. I have no idea why, though the "ID strings" of things like "GDIW-AR" and "GDIW-BR" it uses to find such recipes might be worth looking into.

@DaCyclops
Copy link
Owner

DaCyclops commented Jan 8, 2018

Hmm, Yeah, I dont think I actually EVER took into consideration the Normal/Expensive options for recipes....

EDIT: wait, checked the wrong commit

Your code will find all the normal/expensive versions that should be updated, but its still going to need the function updated to update normal/expensive recipes.....

@DaCyclops
Copy link
Owner

I cant see any major issues right now, but I might add in a little "to be sure" checking of vrn.ingredients and vrn.results just to be sure. I will merge them when I have a moment to double-check the code at home.

@ReikaKalseki
Copy link
Contributor Author

I have tested it and it works (rocket fuel):

https://i.imgur.com/RehZWi3.jpg

@PCbIX
Copy link

PCbIX commented Jan 19, 2019

Such as mentioned here, as well as I suspect in this case.

Can you pls fix you patched version to work state pls
i tried your latest version and recieve:
33.348 Error ModManager.cpp:1024: Failed to load mod "GDIW": GDIW/data-final-fixes.lua:74: bad argument #1 to 'pairs' (table expected, got nil)
33.349 Loading mod core 0.0.0 (data.lua)
33.496 Checksum for core: 2304860305
33.511 Error ModManager.cpp:1024: Error in assignID, recipe-category with name 'crafting' does not exist.

@ReikaKalseki
Copy link
Contributor Author

Why the hell are you writing that here, which has no bearing on anything you are saying?

@DaCyclops DaCyclops merged commit 2775a3e into DaCyclops:master Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants