Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imported: Use 'Includes' for regression test selection #5

Closed
DaGeRe opened this issue Nov 15, 2021 · 4 comments
Closed

Imported: Use 'Includes' for regression test selection #5

DaGeRe opened this issue Nov 15, 2021 · 4 comments

Comments

@DaGeRe
Copy link
Owner

DaGeRe commented Nov 15, 2021

This issue has been imported from an old repository. It was originally created by @Schattensilber at 2021-02-26T13:20:16Z with number #5

The Includes option allows to specify only a subset of tests to be measured by peass. At the moment the regression test selection phase seems to still instrument all tests regardless of Includes.

@DaGeRe
Copy link
Owner Author

DaGeRe commented Nov 15, 2021

This comment has been imported from an old repository. It was originally created by @DaGeRe at 2021-02-26T16:39:08Z

Thanks for the issue. I will fix this in the next days.

@DaGeRe DaGeRe closed this as completed Nov 15, 2021
@DaGeRe
Copy link
Owner Author

DaGeRe commented Nov 15, 2021

This comment has been imported from an old repository. It was originally created by @DaGeRe at 2021-03-01T11:43:18Z

It is now checked whether a test is included or not, therefore, since DaGeRe/peass@cbff8f1, this should also work for the regression test selection (RTS). It is implemented by checking for the executions whether a test is included.

Could you check whether this works for you? For testing, you should clean ~/.peass/ before execution and use a fresh build of peass and peass-ci.

One thing that will not work is first including only TestA, executing the RTS and then including TestB - TestB will not be selected afterwards. After the initial identification of tests and dependencies in the RTS, updates will only be performed on known tests; therefore, extending the definition of includes will currently not work (but shortening the definition will work). The easiest implementation for this would be to save the includes of the last execution and re-execute the initial identification of tests, if the definition of includes is extended; I'll try to implement this in the next days.

@DaGeRe
Copy link
Owner Author

DaGeRe commented Nov 15, 2021

This comment has been imported from an old repository. It was originally created by @Schattensilber at 2021-03-03T07:50:43Z

Currently not working at all. Console readout is very different depending on whether includes is set or not. Will give you details through different channel.

@DaGeRe
Copy link
Owner Author

DaGeRe commented Nov 15, 2021

This comment has been imported from an old repository. It was originally created by @Schattensilber at 2021-03-11T14:11:55Z

Seems to work now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant