Write configuration file to pass env variables/properties for Android projects. #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
DaGeRe
reviewed
Dec 6, 2022
| * Writes Android configuration file inside "app/src/main/resources" to pass values for KoPeMe inside the emulator. | ||
| */ | ||
| private void writeAndroidConfigJson() { | ||
| ObjectMapper mapper = new ObjectMapper(); |
There was a problem hiding this comment.
Thanks for the PR. Is there any reason to create a new ObjectMapper instead of the ObjectMapper from Constants?
There was a problem hiding this comment.
Didn't see that there is already an ObjectMapper.
I've changed it here a2ca497
|
Thanks for the update, looks fine to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a configuration file
kopeme_config.jsonfor Android projects inside its resources folder.Writes the values of
"KOPEME_HOME"environment variable and"kopeme.workingdir"property into it.