Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add java compatibility configuration #127

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

metint
Copy link
Contributor

@metint metint commented Dec 12, 2022

@metint
Copy link
Contributor Author

metint commented Dec 13, 2022

@DaGeRe I checked the code and I realized that the compatibility related modification is already executed only if isUseAnbox() returns true. So it shouldn't effect the other users.

@DaGeRe
Copy link
Owner

DaGeRe commented Dec 13, 2022

You're right, than this is fine, I'll merge it.

In general, it would be nice to have more fine-grained methods (currently, methods tend to be a big lengthy). I'll have a quick look at it and refactor it where possible.

@DaGeRe DaGeRe merged commit 5f8ddee into DaGeRe:develop Dec 13, 2022
@DaGeRe
Copy link
Owner

DaGeRe commented Dec 13, 2022

To improve the readability, I extracted the GradleBuildfileEditorAnbox: https://github.com/DaGeRe/peass/blob/develop/dependency/src/main/java/de/dagere/peass/execution/gradle/GradleBuildfileEditorAnbox.java Feel free to further improve the structure.

@metint
Copy link
Contributor Author

metint commented Dec 14, 2022

Thank you. I will also have a detailed look paying attention to method lengths later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants