Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] comparison with java.lang class names #55

Merged

Conversation

stro18
Copy link
Contributor

@stro18 stro18 commented Mar 25, 2022

Description
Some classes of java.lang use type parameters. Since the type parameter of the variable typeName was removed before, we need to add it again for the comparison.

@stro18 stro18 changed the title [Fix] comparison with java.lang class names in FQNDeterminer [Fix] comparison with java.lang class names Mar 25, 2022
@DaGeRe
Copy link
Owner

DaGeRe commented Mar 25, 2022

Thanks for the PR, the idea looks fine.

Could you also provide a simple test case for TestFQNDeterminer with one of such java.lang classes that uses generics?

@stro18
Copy link
Contributor Author

stro18 commented Mar 25, 2022

Sure.

@DaGeRe
Copy link
Owner

DaGeRe commented Mar 25, 2022

Looks fine, thanks!

@DaGeRe DaGeRe merged commit f1e5023 into DaGeRe:develop Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants