Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only center the mouse if we get a mouse event with relative motion #624

Merged
merged 1 commit into from
May 26, 2022

Conversation

slouken
Copy link
Contributor

@slouken slouken commented Apr 23, 2022

For more information, see the discussion in libsdl-org/SDL#5569

Fixes #600

@smcv
Copy link

smcv commented Apr 23, 2022

This would probably allow #621 to be reverted, too.

@slipher
Copy link
Member

slipher commented Apr 24, 2022

@necessarily-equal claimed this will not fix it when I suggested the same. #621 (comment)

@illwieckz
Copy link
Member

Even if it may be not enough (are you sure?), maybe this is still wanted anyway? @slipher @necessarily-equal

@illwieckz
Copy link
Member

<illwieckz> perturbed, do you thing something prevents that to be merged? https://github.com/DaemonEngine/Daemon/pull/624
<illwieckz> even if it's not 100% better, if it's already 50% better we may still merge it?
<perturbed> i don't have a problem
<afontain> I'd say we should merge it
<illwieckz> okok

@illwieckz illwieckz merged commit 7be8413 into DaemonEngine:master May 26, 2022
@illwieckz
Copy link
Member

Thank you @slouken! 👍️👍️👍️👍️👍️

@slouken
Copy link
Contributor Author

slouken commented May 26, 2022

You're welcome!

@necessarily-equal
Copy link
Contributor

NixOS 22.05 updated to SDL2.0.20, I can confirm that this PR fixes the issue

necessarily-equal added a commit to necessarily-equal/nixpkgs that referenced this pull request Jun 4, 2022
necessarily-equal added a commit to necessarily-equal/nixpkgs that referenced this pull request Jun 5, 2022
necessarily-equal added a commit to necessarily-equal/nixpkgs that referenced this pull request Jun 5, 2022
@necessarily-equal

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDL input is buggy in version 2.16 and later
5 participants