Rewrite SDL warning to fix build #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…6 and 2.20, ref DaemonEngine#600 See DaemonEngine#600 (comment) Thanks ZTM for the report.
…2-config.cmake is available It looks like `find_package(SDL2 CONFIG)` still requires `find_package(SDL2)`.
illwieckz
force-pushed
the
sdlversion
branch
2 times, most recently
from
4bc1a27
to
d74db34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix version, see SDL input is buggy in version 2.16 and later #600 (comment)
fix previously merged cmake: print a warning if SDL version is between 2.16 and 2.20 included, ref #600 #621 which was in fact breaking build if
sdl2-config.cmakewas available but the workspace was empty brand new, it looks likefind_package(SDL2 CONFIG)still requiresfind_package(SDL2).this code may be removed later in favor of Only center the mouse if we get a mouse event with relative motion #624 but the priority is to make
masterbuild again.