Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to visualize in the dagshub gallery view #444

Merged
merged 6 commits into from
Mar 25, 2024

Conversation

kbolashev
Copy link
Member

@kbolashev kbolashev commented Mar 7, 2024

Adds a parameter visualizer param to the visualize function, that either shows the thing in dagshub or fiftyone. Default is still fiftyone for now to keep backwards compat.
once major version is bumped, set the default of the visualize to "dagshub"

@kbolashev kbolashev added the enhancement New feature or request label Mar 7, 2024
@kbolashev kbolashev self-assigned this Mar 7, 2024
Copy link

dagshub bot commented Mar 7, 2024

@kbolashev kbolashev marked this pull request as ready for review March 25, 2024 08:25
@kbolashev kbolashev requested a review from simonlsk March 25, 2024 08:27
@kbolashev
Copy link
Member Author

Copy link
Contributor

@simonlsk simonlsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Default seems to be DagsHub here or did I miss something?

@kbolashev
Copy link
Member Author

Oops, forgot that I reset the default too... Should probably set it to fiftyone and then flip it later

@kbolashev kbolashev merged commit bf3832a into master Mar 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants