Add fds push and save #34
Conversation
# Conflicts: # fds/services/dvc_service.py
…s to be made, but it works as a start. Next steps: 1. Add the ability to intelligently add a remote 2. Add `fds pull` and `fds load`
And added the improved error handling to `push` and `save` # Conflicts: # fds/services/fds_service.py
| help='saves all project files to a new version and pushes them to your remote' | ||
| ) | ||
| parser_save.add_argument('-gr', '--git-remote', help="git remote name, default 'origin'", default="origin") | ||
| parser_save.add_argument('-dr', '--dvc-remote', help="dvc remote name, default 'origin'", default="origin") |
There was a problem hiding this comment.
Maybe add a flag for the branch name?
There was a problem hiding this comment.
I want it to be simple. It's probably also a bad idea to have these flags. I'm actually thinking of removing them, once we implement the "check if there is a remote added for both, then just run it" it has to be dead simple
There was a problem hiding this comment.
The branch flag is a nice-to-have since 90% of the time it will be the same branch you're currently on.
But I strongly disagree about removing these flags - I think you'll make the tool unusable in many cases, and that whoever doesn't want to change the remote names, doesn't have to
There was a problem hiding this comment.
One thing which WOULD be nice is to automatically detect the default remote based on .dvc/config and use that as the default value, but that's more advanced - we're working on that ability in #53
|
I fixed some of the changes you made. The tests for DVC all fail, not sure if it's related to what I'm doing. |
| help='saves all project files to a new version and pushes them to your remote' | ||
| ) | ||
| parser_save.add_argument('-gr', '--git-remote', help="git remote name, default 'origin'", default="origin") | ||
| parser_save.add_argument('-dr', '--dvc-remote', help="dvc remote name, default 'origin'", default="origin") |
There was a problem hiding this comment.
The branch flag is a nice-to-have since 90% of the time it will be the same branch you're currently on.
But I strongly disagree about removing these flags - I think you'll make the tool unusable in many cases, and that whoever doesn't want to change the remote names, doesn't have to
| help='saves all project files to a new version and pushes them to your remote' | ||
| ) | ||
| parser_save.add_argument('-gr', '--git-remote', help="git remote name, default 'origin'", default="origin") | ||
| parser_save.add_argument('-dr', '--dvc-remote', help="dvc remote name, default 'origin'", default="origin") |
There was a problem hiding this comment.
One thing which WOULD be nice is to automatically detect the default remote based on .dvc/config and use that as the default value, but that's more advanced - we're working on that ability in #53
This adds the functionality to
fds pushto both git and dvc remotes at the same time, as well asfds savewhich efficiently adds, commits, and pushes all changes in the project to a given remote.