Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display player errors and prepare for client websockets (first attempt) #141

Closed
wants to merge 7 commits into from

Conversation

Neraste
Copy link
Member

@Neraste Neraste commented Apr 25, 2022

This PR prepares for the use of websockets on the client and has numerous side effects:

  • Digest data are stored in different parts of the state (the state is digest-agnostic);
  • Playlist entries in digest have an estimated date of play computed by the client;
  • Played and queuing playlist entries can be accessed in a library fashion (using pagination);
  • Player errors can be fully accessed in a library fashion (initial aim of the PR, fix Add view to display playlist errors #111).

@Neraste Neraste added enhancement New feature or request refactor Make things more beautiful inside, but same outside labels Apr 25, 2022
@Neraste Neraste added this to the 1.9.0 milestone Apr 25, 2022
@Neraste Neraste self-assigned this Apr 25, 2022
@Neraste Neraste changed the title Tell us how to make Pull Requests work better for you with four quick questions. Display player errors and prepare for client websockets Display player errors and prepare for client websockets Apr 25, 2022
@odrling odrling mentioned this pull request Feb 16, 2024
@Neraste
Copy link
Member Author

Neraste commented Feb 25, 2024

This PR started to diverge too much since #138 (I think), it's becoming impossible to resolve the conflicts. I'm considering to re-do this PR again.

@Neraste
Copy link
Member Author

Neraste commented Feb 25, 2024

Closed in favor of #156.

@Neraste Neraste closed this Feb 25, 2024
@Neraste Neraste deleted the feature/111_player_errors branch February 25, 2024 20:26
@Neraste Neraste changed the title Display player errors and prepare for client websockets Display player errors and prepare for client websockets (first attempt) Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor Make things more beautiful inside, but same outside
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add view to display playlist errors
1 participant