Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make goreport happy #6

Merged
merged 2 commits into from
Feb 16, 2017
Merged

Make goreport happy #6

merged 2 commits into from
Feb 16, 2017

Conversation

arkady-emelyanov
Copy link
Contributor

applying ineffassign, gofmt and misspell suggested fixes (formatting, unused vars, etc..)

@codecov
Copy link

codecov bot commented Feb 16, 2017

Codecov Report

Merging #6 into master will decrease coverage by -0.14%.
The diff coverage is 95%.

@@            Coverage Diff            @@
##           master      #6      +/-   ##
=========================================
- Coverage   89.64%   89.5%   -0.14%     
=========================================
  Files           7       7              
  Lines         309     305       -4     
=========================================
- Hits          277     273       -4     
  Misses         19      19              
  Partials       13      13
Impacted Files Coverage Δ
pkg/kubectl/types.go 100% <ø> (ø)
pkg/kubectl/command.go 77.77% <100%> (ø)
pkg/reference/garbage.go 100% <100%> (ø)
pkg/kubectl/helpers.go 75% <100%> (ø)
pkg/kubectl/api.go 91.66% <100%> (ø)
pkg/reference/decoder.go 100% <100%> (ø)
pkg/kubectl/parser.go 78.75% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 994bade...457eb10. Read the comment docs.

@arkady-emelyanov arkady-emelyanov merged commit ecdb044 into master Feb 16, 2017
@arkady-emelyanov arkady-emelyanov deleted the goreport branch February 16, 2017 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant