-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Horizontal Zoom #83
base: master
Are you sure you want to change the base?
Conversation
Hey @trirpi, Thanks for starting this. Is this already functional or still a work in progress? Couple comments on the coding style (sorry this should be documented in a
Also I think (not sure) that What would be great for this as well, is that it would work with track-pad zoom movement (I'm on Mac and I'd love to have it work in addition to the |
It's still WIP, I've marked it as such now. Thanks a lot for the feedback, I'll incorporate it! There is a JUCE event handler for the track pad zoom movement, so that should be quite easy to add once I finish this. |
Seems to work quite well now. One enhancement would be keeping the same place in view when zooming. So, I'll still try to do that. It might also be nice to have normal scroll, perform a horizontal scroll on the combined audio region. |
This PR introduces horizontal scrolling using ctrl+scroll as raised in #36.