Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BackedEnum could not be converted to int #117

Merged
merged 13 commits into from
Oct 26, 2022

Conversation

dmitryuk
Copy link
Contributor

Closes #115

@dmitryuk
Copy link
Contributor Author

I didn't fixed some cs-fixer errors of files I have not touched.

@DamienHarper
Copy link
Owner

@dmitryuk thanks for the contrib, much appreciated.

Copy link
Owner

@DamienHarper DamienHarper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as enum keyword is available in PHP >= 8.1.0 only, and PHPStan not being able to ignore lines conditionally, I think it worth:

  1. duplicating phpstan.neon file to phpstan-74.neon and phpstan-80.neon for example and tailor them to ignore relevant files
  2. Update CI (.github/workflows/ci-2x.yml file) to use the relevant PHPStan config file regarding PHP version used.

That should fix current issues with CI. You could even revert your latest commits about PHPstan, they should not be required if PHPStan uses dedicated config files per PHP version.

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #117 (f950258) into master (453deba) will increase coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
+ Coverage   94.71%   94.86%   +0.14%     
==========================================
  Files          40       40              
  Lines        1439     1441       +2     
==========================================
+ Hits         1363     1367       +4     
+ Misses         76       74       -2     
Impacted Files Coverage Δ
...vider/Doctrine/Auditing/Transaction/AuditTrait.php 95.04% <100.00%> (+2.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@DamienHarper DamienHarper merged commit e2703a9 into DamienHarper:master Oct 26, 2022
@DamienHarper
Copy link
Owner

Thanks again @dmitryuk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BackedEnum could not be converted to int
2 participants