-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BackedEnum could not be converted to int #117
Conversation
I didn't fixed some cs-fixer errors of files I have not touched. |
@dmitryuk thanks for the contrib, much appreciated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as enum
keyword is available in PHP >= 8.1.0 only, and PHPStan not being able to ignore lines conditionally, I think it worth:
- duplicating
phpstan.neon
file tophpstan-74.neon
andphpstan-80.neon
for example and tailor them to ignore relevant files - Update CI (
.github/workflows/ci-2x.yml
file) to use the relevant PHPStan config file regarding PHP version used.
That should fix current issues with CI. You could even revert your latest commits about PHPstan, they should not be required if PHPStan uses dedicated config files per PHP version.
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
==========================================
+ Coverage 94.71% 94.86% +0.14%
==========================================
Files 40 40
Lines 1439 1441 +2
==========================================
+ Hits 1363 1367 +4
+ Misses 76 74 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Thanks again @dmitryuk |
Closes #115