Test integration with the fixtures. #95 #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DamienHarper
requested changes
Apr 15, 2022
| */ | ||
| private function value(EntityManagerInterface $entityManager, Type $type, $value) | ||
| private function value(EntityManagerInterface $entityManager, Type $type, $value): mixed |
There was a problem hiding this comment.
Same here, this will break with PHP 7.x
src/Provider/Doctrine/Persistence/Reader/Filter/RangeFilter.php
Outdated
Show resolved
Hide resolved
src/Provider/Doctrine/Persistence/Reader/Filter/RangeFilter.php
Outdated
Show resolved
Hide resolved
SanderVerkuil
force-pushed
the
fix/issue-95
branch
from
c9e61f7
to
aa61751
Compare
SanderVerkuil
force-pushed
the
fix/issue-95
branch
from
aa61751
to
82e2077
Compare
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
==========================================
+ Coverage 94.47% 94.75% +0.27%
==========================================
Files 40 40
Lines 1431 1431
==========================================
+ Hits 1352 1356 +4
+ Misses 79 75 -4
Continue to review full report at Codecov.
|
DamienHarper
approved these changes
Apr 16, 2022
SanderVerkuil
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writes another tests based with fixtures, but for some reason the issue doesn't come up here, while it should. Maybe it has something to do with garbage collection, or some other weird optimization from Doctrine?