Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix SingleCompFlash - Solid sublimation #161

Merged
merged 1 commit into from
Jun 14, 2021
Merged

BugFix SingleCompFlash - Solid sublimation #161

merged 1 commit into from
Jun 14, 2021

Conversation

Greg66
Copy link
Contributor

@Greg66 Greg66 commented Jun 13, 2021

Added and fixed solid sublimation for all kinds flash in this PP

Added and fixed solid sublimation for all kinds flash in this PP
@DanWBR
Copy link
Owner

DanWBR commented Jun 13, 2021

@Greg66 did you test your modifications with compounds that have no temperature of fusion defined, i.e. pseudocompounds, user-defined, compounds from dbs other than chemsep...

@Greg66
Copy link
Contributor Author

Greg66 commented Jun 14, 2021

Yes, i did some tests for that scenario as well. It's all behaving well.

A basic scenario was checked with all available flash procedures. Pure CO2 was tested for all situations: vapor, liquid, solid, partial sublimation and partial evaporation from liquid.

After that i modified the CO2 component by replacing temperature of fusion and enthalpy of fusion with a value of zero ("0") to simulate a not well defined component. This later situation is a fall back to your original calculation procedures and works without problems. As no data for solid is defined a liquid phase is calculated instead of solid now. The liquid range extends down to 0 K (which is not a realistic behavior).

@DanWBR
Copy link
Owner

DanWBR commented Jun 14, 2021

@Greg66 Ok, great!

@DanWBR DanWBR merged commit 827845a into DanWBR:windows Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants