Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

umi collapse fails with fastq input #1

Closed
gfialk opened this issue Mar 23, 2020 · 6 comments
Closed

umi collapse fails with fastq input #1

gfialk opened this issue Mar 23, 2020 · 6 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@gfialk
Copy link

gfialk commented Mar 23, 2020

umicollapse is failing whan using fastq input. The command I'm running is:
umicollapse fastq -i in.fastq.gz -o out.fastq.gz
and I'm getting the following error:
Exception in thread "main" java.lang.ClassCastException: class umicollapse.util.FASTQRead cannot be cast to class umicollapse.util.SAMRead (umicollapse.util.FASTQRead and umicollapse.util.SAMRead are in unnamed module of loader 'app')
at umicollapse.merge.MapQualMerge.merge(MapQualMerge.java:9)
at umicollapse.main.DeduplicateFASTQ.deduplicateAndMerge(DeduplicateFASTQ.java:53)
at umicollapse.main.Main.main(Main.java:166)

@Daniel-Liu-c0deb0t
Copy link
Owner

That's because FASTQ reads do not have a mapping quality, so the default mapping quality merging scheme cannot be used. Try adding --merge avgqual to the command-line arguments.

@Daniel-Liu-c0deb0t
Copy link
Owner

Daniel-Liu-c0deb0t commented Mar 24, 2020

A better warning (or a different default setting) probably should be provided, so this needs to be worked on.

@Daniel-Liu-c0deb0t Daniel-Liu-c0deb0t added enhancement New feature or request help wanted Extra attention is needed labels Mar 24, 2020
@gfialk
Copy link
Author

gfialk commented Apr 1, 2020 via email

@Daniel-Liu-c0deb0t
Copy link
Owner

Currently, there is no way to do so. Of course, this should not be too hard to implement as a optional flag, like UMI-tools. However, I chose to not implement it because efficiency must be sacrificed in order to collect extra statistics.

@Daniel-Liu-c0deb0t
Copy link
Owner

When deduplicating FASTQ files, merging using average quality scores is now the default, so this issue is resolved.

@gfialk
Copy link
Author

gfialk commented Oct 17, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants