Depend on library projects rather than published artifacts

[PaulKlauser]

This allows the sample apps to be used to test changes to the libraries without needing to publish

[PaulKlauser]

I found this to make contributing to this repo easier 😃 Let me know if there's an unintended side-effect to this that I'm not considering.

[DanielMartinus]

Hey @PaulKlauser, thanks for your contribution. Unfortunately this won't work since the api included library won't be included when building the konfetti-xml or konfetti-compose. Still have to work on a solution for that

[PaulKlauser]

@DanielMartinus per your comment about the api project not being included: makes sense, if we make this api project(':konfetti:core'), that would solve it right?

[DanielMartinus]

Unfortunately transitive dependencies don't work great when building an aar. Aar only includes the files of that particular module. It's able to use other modules to compile but unfortunately not able to expose files from other transitive modules. Either you'll have to use fat aar to create an aar or pull in the transitive dependency externally like I do now. I agree that the current setup is suboptimal. I'm going to dive into merging all the modules again and separate the internal code by package which seems to me a bit of an improvement. It'll make it easier for external contributions and publishing new releases.

[PaulKlauser]

Ah right. Will bringing Compose into the library have any unintended side-effects for devs that aren't using Compose?

[PaulKlauser]

Closing, since this won't actually work when publishing the library's aar

[PaulKlauser]

@DanielMartinus it actually looks like maven-publish will generate the POM to point at the published dependency, even if the gradle file is pointed at the local project dependency. I can see this behavior by running ./gradlew konfetti:xml:generatePomFileForReleasePublication and looking at the output POM file.

Looks like the issue is just that the artifactId is named core instead of konfetti-core, which is what the core module is being published to so it ends up not matching.

The solution would be to set the project name explicitly to konfetti-core which can be done by changing the directory name, or adding a line to the settings.gradle, which I'll add to this PR in a second

[DanielMartinus]

See #295 with a setup that works using the local core library and where publishing used the remote core dependency