Support hex and other numbers in ranges #345
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #342
Originally, I used
eval
, because at this point we should have guaranteed that theLiteral
is of a reasonable form. But this seems a little risky. Instead I switched toparseInt
which seems to cover the cases we care about (given CoffeeScript's weird semantics with floats).I tried to get BigInt literals to work too, but they're annoying to work with because even
+= 1
doesn't work (can't mix BigInts with regular numbers). Anyway, they're unlikely to be useful, as they likely have length more than 20.