Skip to content
This repository has been archived by the owner on Mar 11, 2023. It is now read-only.

Streaming: locations filter fix #169

Closed
DanielaSfregola opened this issue Oct 24, 2017 · 3 comments
Closed

Streaming: locations filter fix #169

DanielaSfregola opened this issue Oct 24, 2017 · 3 comments

Comments

@DanielaSfregola
Copy link
Owner

DanielaSfregola commented Oct 24, 2017

This discussion follows PR #165 --- original discussion is here. I am gonna copy the relevant messages and continue the discussion here

@DanielaSfregola
Copy link
Owner Author

@DanielaSfregola was saying:

Probably we should use a case class here rather than simple tuples....but how should we call it? we already have a case class Location (that is quite different) and used in the REST Client

@DanielaSfregola
Copy link
Owner Author

@allantl was saying:

There are some improvements that can be made here. Looking at the official twitter java client which is quite outdated here, seems that each bounding box location must be in the form of (southwest coordinate, northeast coordinate).

We can create case classes similar to the link above. Not sure about the name though. For reference, elasticsearch has similar usecase.

Also, looking at this doc, most coordinates are in the form of [LONG,LAT], except geo attribute [LAT, LONG], we can improve case classes such as Area, Coordinates. It would be another breaking change.

@DanielaSfregola
Copy link
Owner Author

@DanielaSfregola was saying:

I wouldn't worry too much about breaking changes: as long as we document them and that they are done with reason, then people are gonna be fine with it. The problem is that we need to do them, bump up the version and properly document them.

We have a few requests already that we know are probably gonna need API breaking changes, for example see #142 and #144.

I am gonna move this discussion into a separate issue (see #169) so that we can discuss it more easily.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant