Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix uninitialized usage of mpz_t #4

Merged
merged 1 commit into from
Dec 21, 2021
Merged

Fix uninitialized usage of mpz_t #4

merged 1 commit into from
Dec 21, 2021

Conversation

yuristuken
Copy link
Contributor

I saw Float.toFixed() crash on some inputs, after digging down this seems to be caused by writing into an uninitialized mpz_t on conversion.
An example in GMP docs suggests mpz_t needs to be initialized before mpz_import calls as well.

@Daninet
Copy link
Owner

Daninet commented Dec 21, 2021

Great catch! Thank you!

@Daninet Daninet merged commit f9d1c46 into Daninet:master Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuristuken @Daninet