Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suport for auto-organizing command files in subfolders #399

Merged
merged 4 commits into from
Jul 3, 2023

Conversation

DannyBen
Copy link
Owner

@DannyBen DannyBen commented Jul 3, 2023

cc #398

@DannyBen
Copy link
Owner Author

DannyBen commented Jul 3, 2023

@EmilySeville7cfg - this PR contains a schema change to the settings.yml file:
👉 40ddcb1

Can you verify my change?
The new Settings option is commands_dir, which is null (~) by default, and accepts any string.

"commands_dir": {
"title": "commands dir",
"description": "A directory to nested command files of the current script",
"oneOf": [
Copy link
Collaborator

@EmilyGraceSeville7cf EmilyGraceSeville7cf Jul 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's better to put schemas containing "type": "null" at the end, not to introduce inconsistency with #/definitions/color. But overall, this change looks nice. ;)

@DannyBen DannyBen merged commit f080ef2 into master Jul 3, 2023
@DannyBen DannyBen deleted the add/commands_dir branch July 3, 2023 10:07
@DannyBen
Copy link
Owner Author

DannyBen commented Jul 3, 2023

Change as you see fit - schemas are your domain :)

@EmilyGraceSeville7cf
Copy link
Collaborator

https://bashly.dannyb.co/usage/settings/#commands_dir is not a valid link. 🤔

@DannyBen
Copy link
Owner Author

DannyBen commented Jul 3, 2023

https://bashly.dannyb.co/usage/settings/#commands_dir is not a valid link. 🤔

Use it. It will be live when the new version is released.

@DannyBen DannyBen mentioned this pull request Jul 3, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants