Fix css_selector option

.github/workflows/test.yml

@@ -10,7 +10,7 @@ jobs:
     runs-on: ubuntu-latest
 
     strategy:
-      matrix: { ruby: ['2.7', '3.0', '3.1', '3.2', head] }
+      matrix: { ruby: ['3.0', '3.1', '3.2', head] }
 
     steps:
     - name: Checkout code

.gitignore

@@ -12,4 +12,5 @@
 /snapcrawl.pstore
 /snaps
 /tmp
-sinatra.pid
+sinatra.pid
+spec/status.txt

lib/snapcrawl/screenshot.rb

@@ -39,8 +39,8 @@ def webshot_capture!(url, image_path)
     def webshot_options
       result = { allowed_status_codes: [404, 401, 403] }
 
-      if Config.selector
-        result[:selector] = Config.selector
+      if Config.css_selector
+        result[:selector] = Config.css_selector
         result[:full] = false
       end
 

snapcrawl.gemspec

@@ -13,7 +13,7 @@ Gem::Specification.new do |s|
   s.executables = ['snapcrawl']
   s.homepage    = 'https://github.com/DannyBen/snapcrawl'
   s.license     = 'MIT'
-  s.required_ruby_version = '>= 2.7'
+  s.required_ruby_version = '>= 3.0'
 
   s.add_runtime_dependency 'addressable', '~> 2.7'
   s.add_runtime_dependency 'colsole', '>= 0.8.1', '< 2'

spec/approvals/config/defaults

@@ -6,10 +6,10 @@ cache_life: 86400
 cache_dir: cache
 snaps_dir: snaps
 name_template: "%{url}"
-url_whitelist: 
-url_blacklist: 
-css_selector: 
+url_whitelist:
+url_blacklist:
+css_selector:
 log_level: 1
 log_color: auto
 skip_ssl_verification: false
-screenshot_delay: 
+screenshot_delay:

spec/approvals/config/minimal

@@ -6,10 +6,10 @@ cache_life: 86400
 cache_dir: cache
 snaps_dir: snaps
 name_template: "%{url}"
-url_whitelist: 
-url_blacklist: 
-css_selector: 
+url_whitelist:
+url_blacklist:
+css_selector:
 log_level: 3
 log_color: false
 skip_ssl_verification: false
-screenshot_delay: 
+screenshot_delay:

spec/snapcrawl/config_spec.rb

@@ -4,14 +4,14 @@
   subject { described_class }
 
   describe '#load' do
-    it 'has defaults' do
+    it 'has defaults', :focus do
       subject.load
-      expect(subject.settings.to_yaml).to match_approval('config/defaults')
+      expect(subject.settings.to_yaml).to match_approval('config/defaults').diff(4)
     end
 
     it 'loads file if it exists and merges it with the defaults' do
       subject.load 'spec/fixtures/config/minimal'
-      expect(subject.settings.to_yaml).to match_approval('config/minimal')
+      expect(subject.settings.to_yaml).to match_approval('config/minimal').diff(4)
     end
 
     context 'when the config file is not found' do

spec/snapcrawl/screenshot_spec.rb

@@ -19,20 +19,20 @@
       expect(File.size outfile).to be > 22_000
     end
 
-    context 'when Config.selector is set' do
+    context 'when Config.css_selector is set' do
       let(:url) { 'http://localhost:3000/selector' }
 
       before do
-        Config.selector = nil
+        Config.css_selector = nil
         subject.save 'tmp/full-page.png'
       end
 
       after do
-        Config.selector = nil
+        Config.css_selector = nil
       end
 
       it 'only captures the selected area' do
-        Config.selector = '.select-me'
+        Config.css_selector = '.select-me'
         subject.save 'tmp/selected-area.png'
         full_size = File.size('tmp/full-page.png')
         selected_size = File.size('tmp/selected-area.png')

spec/spec_helper.rb

@@ -18,4 +18,5 @@
 require_relative 'spec_mixin'
 RSpec.configure do |config|
   config.include SpecMixin
+  config.example_status_persistence_file_path = 'spec/status.txt'
 end