Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLF4J Loggers should be CONSTANT #9

Closed
dhughes-xumak opened this issue Sep 2, 2017 · 2 comments
Closed

SLF4J Loggers should be CONSTANT #9

dhughes-xumak opened this issue Sep 2, 2017 · 2 comments

Comments

@dhughes-xumak
Copy link
Member

Since SLF4J Logger is immutable, our static final reference constants should be all CAPS. Here is one example:

private static final Logger log = LoggerFactory.getLogger(OSGiUtils.class);

Further reading: https://stackoverflow.com/a/9510335

@dhughes-xumak
Copy link
Member Author

label:enhancement

@jbarrera-xumak
Copy link
Member

The changes were merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants