Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes Logger variable name to comply with naming standards #18

Merged
merged 3 commits into from
Oct 16, 2017
Merged

Changes Logger variable name to comply with naming standards #18

merged 3 commits into from
Oct 16, 2017

Conversation

chentex
Copy link
Contributor

@chentex chentex commented Oct 7, 2017

Making changes referencing Issue #9

jbarrera-xumak
jbarrera-xumak reviewed Oct 11, 2017
View reviewed changes
Copy link
Member

@jbarrera-xumak jbarrera-xumak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes should be only for those that are statics, however we could change to static and private those that are not in abstract classes.

@chentex
Copy link
Contributor Author

chentex commented Oct 11, 2017

Thanks, will work on the change today.

jbarrera-xumak
jbarrera-xumak approved these changes Oct 16, 2017
View reviewed changes
Copy link
Member

@jbarrera-xumak jbarrera-xumak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for your collaboration.

@jbarrera-xumak jbarrera-xumak merged commit 6531fa1 into DantaFramework:master Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbarrera-xumak jbarrera-xumak jbarrera-xumak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chentex @jbarrera-xumak