Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating class with common functionality in AEM and Jahia for templat… #22

Merged
merged 7 commits into from
Jan 9, 2018

Conversation

josecarlosgt
Copy link
Member

…e content model implementation.

This class contains common functionality (properties and methods) found in AEM and Jahia template content model implementations.

@josecarlosgt
Copy link
Member Author

The BND plugin is left as follows:

  • com.github.jknack.handlebars dependency is exported by the Core project. Thus, AEM and Jahia projects do not need to embed it. The reason for this is that it is not possible to embed handlebars in all Core, AEM and Jahia projects. Attempting to doing so raises a LinkageErrorError exception as the server tries to load the same class twice.

  • Give that both AEM and Jahia projects will use handlebars classes exported by Core, all handlebars dependencies: mozilla.javascript, antlr4-runtime, commons-lang3 are embedded only in Core and not in the AEM and Jahia projects anymore.

@jbarrera-xumak
Copy link
Member

For bundles that are being embedded I prefer export them using the tag <_exportcontents> and not as it is in the API bundle, to avoid conflicts.

@josecarlosgt
Copy link
Member Author

Done in the previous commit. It builds successfully for both AEM and Jahia. I will run more tests tomorrow uninstalling the bundles.

@jbarrera-xumak
Copy link
Member

Ok thanks, could you also do rebase form master and update the changelog file please?

@josecarlosgt josecarlosgt force-pushed the cleanup/refactor-TemplateContentModelImpl branch from 05da1ad to 89dda90 Compare December 22, 2017 15:13
@josecarlosgt
Copy link
Member Author

Done. Commits in this branch were moved ahead and CHANGELOG file was updated in previous commit.

@josecarlosgt
Copy link
Member Author

Last update to the CHANGELOG was re-written to make it standard with other updates.

@@ -0,0 +1,299 @@
/**
* Danta AEM Bundle
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @josecarlosgt, Could you fix the the bundle name, please?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link
Member

@jbarrera-xumak jbarrera-xumak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@jbarrera-xumak jbarrera-xumak merged commit bdbc115 into master Jan 9, 2018
@ehernandez-xk ehernandez-xk deleted the cleanup/refactor-TemplateContentModelImpl branch August 20, 2018 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants