-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating class with common functionality in AEM and Jahia for templat… #22
Creating class with common functionality in AEM and Jahia for templat… #22
Conversation
The BND plugin is left as follows:
|
For bundles that are being embedded I prefer export them using the tag <_exportcontents> and not as it is in the API bundle, to avoid conflicts. |
Done in the previous commit. It builds successfully for both AEM and Jahia. I will run more tests tomorrow uninstalling the bundles. |
Ok thanks, could you also do rebase form master and update the changelog file please? |
05da1ad
to
89dda90
Compare
Done. Commits in this branch were moved ahead and CHANGELOG file was updated in previous commit. |
Last update to the CHANGELOG was re-written to make it standard with other updates. |
@@ -0,0 +1,299 @@ | |||
/** | |||
* Danta AEM Bundle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @josecarlosgt, Could you fix the the bundle name, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
…e content model implementation.
This class contains common functionality (properties and methods) found in AEM and Jahia template content model implementations.