Validation #151
Validation #151
Conversation
The previous nightly version specified (nightly-2019-03-05) had an issue where components where not supported on Windows. 2018 versions had an issue with some wasm memory functions not being finalised (see rust-lang/rust#56292). This could all be wrong but I found this version worked for me where others didn't.
This tests the proofs-of-concept for the validation code. It is not currently integrated into the test suites or CI.
This is what I'd used previously and it had always worked well for me.
Ok, I'm not sure if I can help in that front, but i'll see if it's feasible to statically link the |
|
Ok, that would be nice to be able to do. |
* wasm-parser: remove parity-wasm dependency * wasm-parser: proof of basic idea * wasm-parser: import instruction mappings from parity-wasm * wasm-parser: build and link with kernel * wasm-parser: fix parsing of import entries * wasm-parser: add missing file * kernel: add test script * wasm-parser: minor cleanup * circleci: don't force rebuild of parity-ethereum * kernel: update tests to be more accurate * kernel: update nightly version for alloc crate * circleci: fix error with parity installation * circleci: fix error in previous commit * wasm-parser: reinclude alloc * wasm-parser: merge Cursor and CodeCursor * circleci: add example contract 2 * circleci: set-up environment for test * circleci: fix example_contract_2 build * wasm-parser: properly validate instructions in syscall * wasm-parser: fix import cursor progression * circleci: remove config step from parity * circleci: clear cache
|
This now uses a smaller parser, which cannabilises parts of parity-wasm for parsing instructions. It's functioning with all the capabilities it needs to perform verification and is successfully integrated into the kernel with tests to prove it. It is not yet tested to demonstrate whether its determination of contract validity are correct, there are still a few items that need to be fixed. |
|
@JakeOShannessy: Let me know when ready for review |
|
I better merge in master first. |
Note: I've removed unimplemented!() from the constructor as it will wipe out all my tests.
|
Master merged in. I made two changes to the proc table stuff in master:
|
|
Let's get this merged in so that we can start coordinating stuff. |
This PR implements the validation code and links it to the kernel as per #141. Currently the validation is functioning, including recognising system calls (although the whitelist needs to be updated).
It also includes cap9-build as per #150. This forms part of the workflow for building conformant cap9 procedures.
More details to come.